Fix Incompatible Target Skipping for test args #13219
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the fix, the test in this patch would error out with the
following message:
The problem was that the
RunfilesSupport
class for theRunfilesProvider
instance was computing the arguments as theincompatible target was being constructed. That meant that the
arguments get evaluated and it would try to resolve things like
$(location :incompatible_dep)
. That can't really succeed so bazelwould throw an error.
This patch makes it so arguments are ignored when constructing an
incompatible target.