Fix _is_shared_library_extension_valid #14021
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consider libfoo-1.0.so.1.0 valid. Do not fail if the name does not contain a '.', return False instead.
|
Build is green now, ptal. |
|
ping. |
|
Having a look at it. |
oquenchil
requested review from
buildbreaker2021
and removed request for
oquenchil
philsc
pushed a commit
to philsc/bazel
that referenced
this pull request
Nov 17, 2021
Consider libfoo-1.0.so.1.0 valid. Do not fail if the name does not contain a '.', return False instead. (cherry picked from commit 23d0969) Fixes bazelbuild#14289. Closes bazelbuild#14021.
Wyverald
pushed a commit
that referenced
this pull request
Nov 17, 2021
Consider libfoo-1.0.so.1.0 valid. Do not fail if the name does not contain a '.', return False instead. (cherry picked from commit 23d0969) Fixes #14289. Closes #14021. Co-authored-by: Benedek Thaler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider libfoo-1.0.so.1.0 valid.
Do not fail if the name does not contain a '.', return False instead.