Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add target label to SpawnExec in the execution log #14818

Closed
wants to merge 1 commit into from

Conversation

chancila
Copy link
Contributor

The execution log is very handy for tracking fine grain build data for analysis, however there's no easy way to correlate the action data to a target, this change simply adds the owning target's label to the SpawnExec info to enable this correlation.

@sgowroji sgowroji added the team-Local-Exec Issues and PRs for the Execution (Local) team label Mar 23, 2022
@chancila
Copy link
Contributor Author

chancila commented Apr 4, 2022

friendly ping

Copy link
Member

@meisterT meisterT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. LGTM

@bazel-io bazel-io closed this in 9f908ca Apr 5, 2022
@brentleyjones
Copy link
Contributor

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Apr 5, 2022
@ckolli5
Copy link

ckolli5 commented Apr 13, 2022

@bazel-io fork 5.2.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Apr 13, 2022
@nkoroste nkoroste mentioned this pull request May 4, 2022
6 tasks
ckolli5 added a commit that referenced this pull request May 9, 2022
The execution log is very handy for tracking fine grain build data for analysis, however there's no easy way to correlate the action data to a target, this change simply adds the owning target's label to the SpawnExec info to enable this correlation.

Closes #14818.

PiperOrigin-RevId: 439516075

Co-authored-by: Cristian Hancila <[email protected]>
tjgq pushed a commit to tjgq/bazel that referenced this pull request Nov 10, 2022
The execution log is very handy for tracking fine grain build data for analysis, however there's no easy way to correlate the action data to a target, this change simply adds the owning target's label to the SpawnExec info to enable this correlation.

Closes bazelbuild#14818.

PiperOrigin-RevId: 439516075
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Local-Exec Issues and PRs for the Execution (Local) team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants