Make coverage --combined_report=lcov skip incompatible tests
#15471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies for the last minute cherry-picks. If they have to wait until 5.3, that's fine too. |
|
@philsc Could you please rebase your branch with the latest release-5.2.0 branch? Thanks! |
Before this patch we see coverage trying to execute incompatible tests. This results in `Can't build this. This target is incompatible` messages. Instead, those tests should just be skipped. This patch makes it so the coverage code only tries to collect coverage artifacts for compatible tests. Artifacts for incompatible tests are ignored. Fixes bazelbuild#15385 Closes bazelbuild#15419. PiperOrigin-RevId: 447710011 (cherry picked from commit 2f1ff6f)
philsc
force-pushed
the
cherry-pick-5.2-fix-incompatible-coverage
branch
from
e986321
to
4bba523
Compare
|
Done |
|
@ckolli5, is it possible that the failing test is flaky? The |
|
@philsc Looks like the errors are flaky. I will re-run the presubmit jobs and see if that is flaky error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch we see coverage trying to execute incompatible
tests. This results in
Can't build this. This target is incompatiblemessages. Instead, those tests should just be skipped.
This patch makes it so the coverage code only tries to collect
coverage artifacts for compatible tests. Artifacts for incompatible
tests are ignored.
(cherry picked from commit 2f1ff6f)
Fixes #15385