Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not count tests as failed that have not started #17160

Closed
wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Jan 6, 2023

Before this commit, when the user interrupted a test run, tests that had not started until that point were counted as failed, whereas tests that were already running were counted as skipped.

With this commmit, both types of tests are counted as skipped.

Before this commit, when the user interrupted a test run, tests that had
not started until that point were counted as failed, whereas tests that
were already running were counted as skipped.

With this commmit, both types of tests are counted as skipped.
@fmeum fmeum marked this pull request as ready for review January 6, 2023 20:20
@fmeum
Copy link
Collaborator Author

fmeum commented Jan 6, 2023

@meisterT Could you review this PR?

@ShreeM01 ShreeM01 added team-Performance Issues for Performance teams awaiting-review PR is awaiting review from an assigned reviewer labels Jan 6, 2023
@meisterT meisterT added team-Core Skyframe, bazel query, BEP, options parsing, bazelrc and removed team-Performance Issues for Performance teams labels Jan 9, 2023
@meisterT
Copy link
Member

meisterT commented Jan 9, 2023

@haxorz introduced this (a long time ago) - looks benign to me, but you might want to have a look.

@haxorz
Copy link
Contributor

haxorz commented Jan 9, 2023

Thanks for the tag, @meisterT !

This is a good change. Thanks for making it, @fmeum !

@haxorz haxorz self-assigned this Jan 9, 2023
@fmeum
Copy link
Collaborator Author

fmeum commented Jan 9, 2023

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Jan 9, 2023
@haxorz
Copy link
Contributor

haxorz commented Jan 12, 2023

Hi, sorry. I should have replaced awaiting-review with awaiting-PR-merge. Done!

@fmeum why did you tag @bazel-io, causing potential release blocker to get added? I don't think this PR is worthy of being a release blocker. I went ahead and removed that tag. Let me know if you disagree though.

@haxorz haxorz added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone awaiting-review PR is awaiting review from an assigned reviewer labels Jan 12, 2023
@brentleyjones
Copy link
Contributor

The label is to indicate that we would like the cherry-pick it into 6.1. If it's not an incompatible change it would be nice to get the label back.

@haxorz haxorz added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Jan 12, 2023
@sgowroji sgowroji removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jan 12, 2023
@fmeum fmeum deleted the interrupted-test-summary branch January 12, 2023 14:17
@ShreeM01
Copy link
Contributor

@bazel-io fork 6.1.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Jan 19, 2023
ShreeM01 added a commit that referenced this pull request Jan 24, 2023
Before this commit, when the user interrupted a test run, tests that had not started until that point were counted as failed, whereas tests that were already running were counted as skipped.

With this commmit, both types of tests are counted as skipped.

Closes #17160.

PiperOrigin-RevId: 501495265
Change-Id: I4dd157c32d70eb46a02070251684899b84c9802e

Co-authored-by: Fabian Meumertzheim <[email protected]>
hvadehra pushed a commit that referenced this pull request Feb 14, 2023
Before this commit, when the user interrupted a test run, tests that had not started until that point were counted as failed, whereas tests that were already running were counted as skipped.

With this commmit, both types of tests are counted as skipped.

Closes #17160.

PiperOrigin-RevId: 501495265
Change-Id: I4dd157c32d70eb46a02070251684899b84c9802e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Core Skyframe, bazel query, BEP, options parsing, bazelrc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants