Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test and fix root symlink edge case in runfiles library #17365

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Test and fix root symlink edge case in runfiles library #17365

merged 1 commit into from
Jan 31, 2023

Commits on Jan 31, 2023

  1. Test and fix root symlink edge case in runfiles library 

    Due to incomplete test coverage for the case of a root symlink named like a Bazel module, the Bash runfiles libraries behaved incorrectly in this case. This commit fixes that and adds proper test coverage for all libraries by adding repo mappings that conflict with the existing rlocation testcase for `config.json`.

Closes bazelbuild#17317.

PiperOrigin-RevId: 505873412
Change-Id: I72019d329b72cab9cf893deb714da8889d371617
    @fmeum
    fmeum committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    1f4bc23 View commit details
    Browse the repository at this point in the history