Make AutoBazelRepositoryProcessor compatible with Java 8 #17460
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The three-argument overload of `Stream#iterate` is only available as of Java 9.
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
|
@cushon Could you review this? Do you see a way to verify Java 8 compatibility in CI with the current setup? At least based on its name |
|
@bazel-io fork 6.1.0 |
bazel-io
removed
the
potential release blocker
LGTM, thanks
I agree that it would be nice to have CI coverage for this as long as targeting Java 8 is supposed. @comius, WDYT about this? |
cushon
approved these changes
Feb 10, 2023
ShreeM01
added
the
awaiting-PR-merge
sgowroji
removed
the
awaiting-PR-merge
ShreeM01
added a commit
that referenced
this pull request
Feb 16, 2023
The three-argument overload of `Stream#iterate` is only available as of Java 9. Fixes #17458 Closes #17460. PiperOrigin-RevId: 509885763 Change-Id: If83d832b3590b8598c0f4163afa3c7054e7c9786 Co-authored-by: Fabian Meumertzheim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The three-argument overload of
Stream#iterateis only available as of Java 9.Fixes #17458