Remove default -s flag from macOS libtool invocation #17489
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-s is the default but it's not supported by llvm's libtool replacement which results in failed links. I don't think we really care about the specifics here, so since it's the default for most folks we can drop it.
keith
force-pushed
the
ks/remove-default-s-flag-from-macos-libtool-invocation
branch
from
62aa88e
to
7e3f2f8
Compare
sgowroji
added
team-Rules-CPP
oquenchil
approved these changes
Feb 20, 2023
oquenchil
added
awaiting-PR-merge
sgowroji
removed
the
awaiting-PR-merge
|
@bazel-io fork 6.4.0 |
This was referenced Sep 8, 2023
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Sep 8, 2023
-s is the default but it's not supported by llvm's libtool replacement which results in failed links. I don't think we really care about the specifics here, so since it's the default for most folks we can drop it. Closes bazelbuild#17489. PiperOrigin-RevId: 511121405 Change-Id: Id0b52f960072100d232fdbf5461dec068c8e3edf
meteorcloudy
pushed a commit
that referenced
this pull request
Sep 8, 2023
-s is the default but it's not supported by llvm's libtool replacement which results in failed links. I don't think we really care about the specifics here, so since it's the default for most folks we can drop it. Closes #17489. Commit ae7cfa5 PiperOrigin-RevId: 511121405 Change-Id: Id0b52f960072100d232fdbf5461dec068c8e3edf Co-authored-by: Keith Smiley <[email protected]>
|
The changes in this PR have been included in Bazel 6.4.0 RC1. Please test out the release candidate and report any issues as soon as possible. If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=last_rc. |
keith
deleted the
ks/remove-default-s-flag-from-macos-libtool-invocation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-s is the default but it's not supported by llvm's libtool replacement which results in failed links. I don't think we really care about the specifics here, so since it's the default for most folks we can drop it.