Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include cause when reporting ActionExecutionException #18169

Closed

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Apr 21, 2023

SkyframeActionExecutor#toActionExecutionException claimed to combine the user-provided message and the exception's message when reporting an error, but did not.

This is fixed so that errors can be diagnosed directly from the build logs, without having to look into java.log.

Work towards #10363

`SkyframeActionExecutor#toActionExecutionException` claimed to combine
the user-provided message and the exception's message when reporting an
error, but did not.

This is fixed so that errors can be diagnosed directly from the build
logs, without having to look into `java.log`.
@fmeum fmeum requested a review from meteorcloudy April 21, 2023 10:03
@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-Performance Issues for Performance teams labels Apr 21, 2023
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Apr 21, 2023
@fmeum
Copy link
Collaborator Author

fmeum commented Apr 21, 2023

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Apr 21, 2023
@keertk
Copy link
Member

keertk commented Apr 21, 2023

@bazel-io fork 6.2.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Apr 21, 2023
@keertk keertk removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Apr 23, 2023
meteorcloudy pushed a commit that referenced this pull request Apr 24, 2023
`SkyframeActionExecutor#toActionExecutionException` claimed to combine the user-provided message and the exception's message when reporting an error, but did not.

This is fixed so that errors can be diagnosed directly from the build logs, without having to look into `java.log`.

Work towards #10363

Closes #18169.

PiperOrigin-RevId: 526195991
Change-Id: I978a6d739c37384121acccccf95e8dcb80ac5d25

Co-authored-by: Fabian Meumertzheim <[email protected]>
@fmeum fmeum deleted the action-execution-exception-cause branch April 24, 2023 10:59
fweikert pushed a commit to fweikert/bazel that referenced this pull request May 25, 2023
`SkyframeActionExecutor#toActionExecutionException` claimed to combine the user-provided message and the exception's message when reporting an error, but did not.

This is fixed so that errors can be diagnosed directly from the build logs, without having to look into `java.log`.

Work towards bazelbuild#10363

Closes bazelbuild#18169.

PiperOrigin-RevId: 526195991
Change-Id: I978a6d739c37384121acccccf95e8dcb80ac5d25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Performance Issues for Performance teams
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants