Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize prefetchInputs. #20557

Closed
wants to merge 3 commits into from
Closed

Optimize prefetchInputs. #20557

wants to merge 3 commits into from

Commits on Dec 15, 2023

  1. Optimize prefetchInputs. 

    Use a pre-allocated array to hold the intermediate transfers to avoid
allocations. Replace some of RxJava code with Futures to avoid RxJava
overheads.

This improves the perfromance of prefetchInputs on a large set of
inputs from ~400ms to ~16ms.

Fixes bazelbuild#20555.
    @coeuvre
    coeuvre committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    2bb70fd View commit details
    Browse the repository at this point in the history

  2. Fix test

    @coeuvre
    coeuvre committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    4f28357 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2023

  1. Address comments

    @coeuvre
    coeuvre committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    a29bcb3 View commit details
    Browse the repository at this point in the history