Commits on Feb 9, 2024

1. Fix a hanging issue with skymeld & --combined_report=lcov. …

   With Skymeld, the combined report is done right before the end of the build. This works fine except for a buggy case:
   - `--nokeep_going`
   - when there's an error that the Coverage action transitively depends on
   - The error would try to interrupt the build, and since we evaluate coverage actions uninterruptibly (consistent with the noskymeld behavior), we're stuck in an infinite loop [1].
   
   This happened because we did not fail fast like we should have. This CL fixes the issue by checking, before generating the combined report, whether we should fail fast.
   
   Fixes bazelbuild#21154
   
   [1] https:/bazelbuild/bazel/blob/026f493a5a403fa5d770cae0b3a3baf8dcf33488/src/main/java/com/google/devtools/build/lib/concurrent/Uninterruptibles.java#L33-L39
   
   PiperOrigin-RevId: 605572100
   Change-Id: I8d57dacca58358771799161352819ec65bef6ac2

   

   joeleba authored and bazel-io committed Feb 9, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for ce8a6ab
   • Browse repository at this point

   Copy the full SHA

   ce8a6ab View commit details

   Browse the repository at this point in the history