Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.1.0] Fix bazel fetch by replacing query with cquery for underlying implementation #21567

Merged
merged 6 commits into from
Mar 5, 2024
Merged

[7.1.0] Fix bazel fetch by replacing query with cquery for underlying implementation #21567

merged 6 commits into from
Mar 5, 2024

Commits on Mar 5, 2024

  1. Use SkyKeyInterner for more SkyKey types. 

    PiperOrigin-RevId: 579840409
Change-Id: I67eeea72f2bb935581f6f7afe71f0b72fb6f4c1a
    @justinhorvitz @meteorcloudy
    justinhorvitz authored and meteorcloudy committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    4cdf785 View commit details
    Browse the repository at this point in the history

  2. Split out VisibleForSerialization from AutoCodec. 

    This annotation is orthogonal to AutoCodec and creates a circular dependency in
a later change.

PiperOrigin-RevId: 579867965
Change-Id: Iff7ab004d7635c32edb9de38231b2d4c93469c6f
    @aoeui @meteorcloudy
    aoeui authored and meteorcloudy committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    e31dbd2 View commit details
    Browse the repository at this point in the history

  3. Streamline code to cache configurations. 

    Work towards platform-based flags: bazelbuild#19409.

PiperOrigin-RevId: 580452068
Change-Id: If94e0fbd9a815bfe3decca21ef1fd58003b4c366
    @katre @meteorcloudy
    katre authored and meteorcloudy committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    9e07fac View commit details
    Browse the repository at this point in the history

  4. explcitly traverse aspects in cquery 

    This CL adds aspect nodes as explicit targets in cquery deps by making
ConfiguredTargetQueryEnvironment generic over a new interface,
CqueryNode, rather than ConfiguredTarget.

CqueryNode is implemented by AspectKey as well as ConfiguredTarget so
that both can be traversed in a deps query.

PiperOrigin-RevId: 595509373
Change-Id: I8a637cd3ed640907d2b1501bcd2b4a4507d183e7
    @meteorcloudy
    Googler authored and meteorcloudy committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    a305a0d View commit details
    Browse the repository at this point in the history

  5. Fix fetch target (fixes bazelbuild#13847) 

    Context:
- Traditional query relies on the initial loading phase of the build, this lacks the context of build configurations (flags, select() logic), leading to potentially inaccurate or over-inclusive dependency listings.

- cquery executes after the analysis phase, where Bazel has resolved configurations and determined how options influence target definitions. This allows cquery to provide the dependencies truly needed for a build under the current settings.

Considering these differences, I'm updating fetch target logic to rely on cquery instead. This ensures that all necessary repositories are fetched for an offline build while avoiding potential over-fetching

PiperOrigin-RevId: 611455579
Change-Id: I2a954476c06182fd9eb78ad86def7bd72f04074a
    @SalmaSamy @meteorcloudy
    SalmaSamy authored and meteorcloudy committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    5a27b74 View commit details
    Browse the repository at this point in the history

  6. Disable testAspectOnAspectDepsAppearInCqueryDeps

    @meteorcloudy
    meteorcloudy committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    fb36025 View commit details
    Browse the repository at this point in the history