Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.2.0] Support key callback in Starlark min/max builtins #21960

Merged
merged 1 commit into from
Apr 10, 2024
Merged

[7.2.0] Support key callback in Starlark min/max builtins #21960

merged 1 commit into from
Apr 10, 2024

Commits on Apr 10, 2024

  1. Support key callback in Starlark min/max builtins 

    This is required by the language spec, but was not implemented in Bazel.

See https:/bazelbuild/starlark/blob/master/spec.md#max

Fixes bazelbuild#15022

Also take the opportunity to adjust sorted's signature for `key` to match.

RELNOTES: Starlark `min` and `max` buitins now allow a `key` callback,
similarly to `sorted`.
PiperOrigin-RevId: 623547043
Change-Id: I71d44aa715793f9f2260f9b20b876694154ff352
    @tetromino @bazel-io
    tetromino authored and bazel-io committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    49746a3 View commit details
    Browse the repository at this point in the history