Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document source of truth for rctx.download* cache key #22716

Closed

Conversation

Silic0nS0ldier
Copy link
Contributor

Documenting the default caching behaviour for rctx.download and rctx.download_and_extract.
 
Related to #22652

@github-actions github-actions bot added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. awaiting-review PR is awaiting review from an assigned reviewer labels Jun 12, 2024
Copy link
Collaborator

@fmeum fmeum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Friendly ping @Wyverald

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jul 17, 2024
@iancha1992
Copy link
Member

@fmeum @Silic0nS0ldier could you please take a look at the conflicts in the file? Thanks!

@Silic0nS0ldier
Copy link
Contributor Author

Conflicts resolved.

@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jul 19, 2024
@fmeum
Copy link
Collaborator

fmeum commented Jul 19, 2024

@bazel-io fork 7.3.0

iancha1992 pushed a commit to iancha1992/bazel that referenced this pull request Jul 19, 2024
Documenting the default caching behaviour for `rctx.download` and `rctx.download_and_extract`.
 
Related to bazelbuild#22652

Closes bazelbuild#22716.

PiperOrigin-RevId: 653878029
Change-Id: I129f9eede2b841483a98d5335651c1d1198aaf76
github-merge-queue bot pushed a commit that referenced this pull request Jul 22, 2024
Documenting the default caching behaviour for `rctx.download` and
`rctx.download_and_extract`.
 
Related to #22652

Closes #22716.

PiperOrigin-RevId: 653878029
Change-Id: I129f9eede2b841483a98d5335651c1d1198aaf76

Commit
d4b416f

Co-authored-by: Jordan Mele <[email protected]>
@iancha1992
Copy link
Member

The changes in this PR have been included in Bazel 7.3.0 RC1. Please test out the release candidate and report any issues as soon as possible.
If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=7.3.0rc1. Thanks!

fmeum pushed a commit to fmeum/bazel that referenced this pull request Aug 22, 2024
Documenting the default caching behaviour for `rctx.download` and `rctx.download_and_extract`.
 
Related to bazelbuild#22652

Closes bazelbuild#22716.

PiperOrigin-RevId: 653878029
Change-Id: I129f9eede2b841483a98d5335651c1d1198aaf76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants