Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[7.3.0] Deduplicate locally executed path mapped spawns (#230… #23290

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Aug 13, 2024

…69)"

This reverts commit ffe1df5.

Causes race conditions, see #23288 for details.

Fixes #23289

@fmeum fmeum requested a review from a team as a code owner August 13, 2024 21:25
@fmeum
Copy link
Collaborator Author

fmeum commented Aug 13, 2024

@Wyverald @iancha1992

@fmeum fmeum mentioned this pull request Aug 13, 2024
5 tasks
@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-Performance Issues for Performance teams team-Remote-Exec Issues and PRs for the Execution (Remote) team labels Aug 13, 2024
@keertk keertk enabled auto-merge (squash) August 13, 2024 22:03
@keertk keertk merged commit 1acfc5f into bazelbuild:release-7.3.1 Aug 13, 2024
51 of 52 checks passed
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Aug 13, 2024
@meteorcloudy
Copy link
Member

I guess this problem also exists at HEAD?

@fmeum
Copy link
Collaborator Author

fmeum commented Aug 14, 2024

It does, but I have a PR out for one of the issues and hope to fix the other one soon. If that doesn't work out in a timely fashion, I'll send a revert for master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Performance Issues for Performance teams team-Remote-Exec Issues and PRs for the Execution (Remote) team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants