[7.4.0] Replace "checking cached actions" message when no action is running. #23357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While we delay the execution phase progress until we execution real actions (see unknown commit), with Skymeld we could still see the following scenario: - Bazel completes the analysis for the first top-level target - Bazel starts execution for the first top-level target, still analyzing other top-level targets - Bazel completes execution for the first top-level target, still running analysis for other top-level targets Prior to this CL, we would have reported something like `[42 / 42] checking cached actions` until we continue with execution (after the next top-level target finishes analysis). Now, we do report `[42 / 42] no actions running`. RELNOTES: Improve progress message in case there are no actions in flight, and display explicitly "no actions running" in that case. PiperOrigin-RevId: 661205481 Change-Id: Ieaf77090ecf3d4979330fcd8229a92afc98c7557
bazel-io
added
team-Remote-Exec
Wyverald
approved these changes
Aug 21, 2024
Merged
via the queue into
bazelbuild:release-7.4.0
with commit Aug 21, 2024
a9a66ae
52 checks passed
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we delay the execution phase progress until we execution real actions (see unknown commit), with Skymeld we could still see the following scenario:
Prior to this CL, we would have reported something like
[42 / 42] checking cached actionsuntil we continue with execution (after the next top-level target finishes analysis). Now, we do report[42 / 42] no actions running.RELNOTES: Improve progress message in case there are no actions in flight, and display explicitly "no actions running" in that case.
PiperOrigin-RevId: 661205481
Change-Id: Ieaf77090ecf3d4979330fcd8229a92afc98c7557
Commit b215cb8