Heuristically path map copts and defines #23630
Closed
+20
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows path mapping to apply to actions that reference execpaths in custom compiler options via location expansion.
github-actions
bot
added
team-Performance
fmeum
requested review from
comius,
a team and
gregestren
and removed request for
lberki,
aranguyen,
a team and
gregestren
fmeum
removed
team-Performance
|
verified that this works on our project which has lots of random uses of things like |
|
@bazel-io fork 7.4.0 |
comius
approved these changes
Sep 23, 2024
comius
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Oct 2, 2024
This allows path mapping to apply to actions that reference execpaths in custom compiler options via location expansion. Work towards bazelbuild#6526 Closes bazelbuild#23630. PiperOrigin-RevId: 680941133 Change-Id: Ia10e2df481dcfe4480cbf9dfb1e12ec3b07d8ab2
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 9, 2024
This allows path mapping to apply to actions that reference execpaths in custom compiler options via location expansion. Work towards #6526 Closes #23630. PiperOrigin-RevId: 680941133 Change-Id: Ia10e2df481dcfe4480cbf9dfb1e12ec3b07d8ab2 Commit b4b35af Co-authored-by: Fabian Meumertzheim <[email protected]>
|
The changes in this PR have been included in Bazel 7.4.0 RC1. Please test out the release candidate and report any issues as soon as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows path mapping to apply to actions that reference execpaths in custom compiler options via location expansion.
Work towards #6526