Add android_external in anticipation of dependency in @bazel_tools #211
+128
−32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To remove all //external:android usages in
@bazel_tools
, all routing to@androidsdk
will go through the new module@android_external
. We have to add it to@rules_android
before we can migrate@bazel_tools
.For backward compatibility, we can't remove all 'bind' calls until
@bazel_tools
is//external
-free. Move bind calls to WORKSPACE.bzlmod because we can't have them stay in module extension implementation. It means the bind call happens before we have@androidsdk
defined, so we add alias at top level to forward the binding to@androidsdk
. However,@rules_android~~android_sdk_repository_extension~androidsdk
is not visible from//external:<blash>
when the root module is not@rules_android
. So the example/basicapp still make direct android_sdk_repository call so its bind calls are in order.