Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up rules_android WORKSPACE #55

Merged

Conversation

ted-xie
Copy link
Contributor

@ted-xie ted-xie commented Dec 1, 2022

  • Separate http_archives into prereqs.bzl
  • Move all dep macro calls and external package manager calls (go_repository, maven_install) into defs.bzl

Significantly reduces the bloat in WORKSPACE, and makes integration by users much easier (only need to call rules_android_prereqs() and rules_android_workspace()).

NOTE: This will eventually be deprecated once we make bzlmod the default dependency manager for rules_android by mandating
--[experimental_]enable_bzlmod in user bazelrc files.

* Separate http_archives into prereqs.bzl
* Move all dep macro calls and external package manager calls
  (go_repository, maven_install) into defs.bzl

Significantly reduces the bloat in WORKSPACE, and makes integration by
users much easier (only need to call rules_android_prereqs() and
rules_android_workspace()).

NOTE: This will eventually be deprecated once we make bzlmod the default
dependency manager for rules_android by mandating
--[experimental_]enable_bzlmod in user bazelrc files.
@copybara-service copybara-service bot merged commit 5f39a71 into bazelbuild:pre-alpha Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant