Fixing CI failures #73
Conversation
comius
requested review from
kotlaja and
ted-xie
and removed request for
kotlaja
.bazelci/postsubmit.yml
Outdated
| - "//android/..." | ||
| - "//rules/..." | ||
| - "-//src/java/com/example/sampleapp/..." | ||
| - "-//src/tools/ak/..." |
There was a problem hiding this comment.
Some subdirectories are missing on github.
.bazelci/postsubmit.yml
Outdated
| - "//test/..." | ||
| - "//android/..." | ||
| - "//rules/..." | ||
| - "-//src/java/com/example/sampleapp/..." |
There was a problem hiding this comment.
Has unexisting deps: "@androidsdk//com.android.support:appcompat-v7-25.0.0",
"@androidsdk//com.android.support:support-v4-25.2.0",
.bazelci/postsubmit.yml
Outdated
| - "//..." | ||
| # test_targets: | ||
| # - "//..." | ||
| - "//src/..." |
There was a problem hiding this comment.
All the targets are included except //examples/..., which need to be build in a separate task, changing the directroy where their WORKSPACE file is.
The examples build works with Bazel@HEAD and using 2 extra flags:
bazel build --experimental_google_legacy_api --experimental_enable_android_migration_apis //...
There was a problem hiding this comment.
Yeah, I think we added these to the repo-level .bazelrc already.
|
You don't need the postsubmit.yml file, the rules_android CI pipeline uses presubmit.yml for both PR and postsubmit |
|
I closed and reopened the PR to trigger the presubmit, you can check the result now |
COAUTHOR=@kotlaja