Skip to content
This repository has been archived by the owner on Oct 2, 2023. It is now read-only.

testing changes to platforms to enable #1203 to work #1205

Merged
merged 8 commits into from
Oct 16, 2019

Conversation

nlopezgi
Copy link
Contributor

(also pulled in changes from #1203 to test)

smukherj1 added a commit to smukherj1/rules_docker that referenced this pull request Oct 11, 2019
@nlopezgi
Copy link
Contributor Author

/gcbrun

@nlopezgi
Copy link
Contributor Author

/gcbrun

@nlopezgi
Copy link
Contributor Author

/gcbrun

@nlopezgi
Copy link
Contributor Author

/gcbrun

@nlopezgi
Copy link
Contributor Author

/gcbrun

@Toxicable
Copy link
Contributor

So updating from 0.12.0 to this commit results in the error:

ERROR: An error occurred during the fetch of repository 'nginx_image_base':
   Pull command failed: 2019/10/12 12:25:18 Running the Image Puller to pull images from a Docker Registry...
2019/10/12 12:25:20 Image pull was unsuccessful: reading image "index.docker.io/library/nginx@sha256:c10f4146f30fda9f40946bc114afeb1f4e867877c49283207a08ddbcf1778790": <empty transport.Error response>
 (/home/f.wiles/.cache/bazel/_bazel_f.wiles/4e95cbad76bfb4ed000904165db39268/external/go_puller_linux/file/downloaded -directory /home/f.wiles/.cache/bazel/_bazel_f.wiles/4e95cbad76bfb4ed000904165db39268/external/nginx_image_base/image -os linux -os-version  -os-features  -architecture amd64 -variant  -features  -name index.docker.io/library/nginx@sha256:c10f4146f30fda9f40946bc114afeb1f4e867877c49283207a08ddbcf1778790)

@Toxicable
Copy link
Contributor

Wait sorry, it may not be this PR that caused it. Since I never got onto 0.12.0 due to the issues over here: bazelbuild/rules_go#2089

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nlopezgi, smukherj1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the lgtm label Oct 16, 2019
@k8s-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@smukherj1
Copy link
Collaborator

/gcbrun

@nlopezgi nlopezgi merged commit 31f8a73 into bazelbuild:master Oct 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants