Remove ios/android/wasm support for gen_rust_project deps #1684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For this change I think you're gonna need to regenerate dependencies by running the target you just updated. |
P1n3appl3
force-pushed
the
rust-analyzer
branch
from
4978f16
to
b57eb68
Compare
P1n3appl3
force-pushed
the
rust-analyzer
branch
from
b57eb68
to
d8ea6b8
Compare
|
I've just regenerated the deps gain. @UebelAndre let me know if there are any other changes you wanted, I think this is ready to merge otherwise. |
UebelAndre
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
crates_vendorfor thegen_rust_projectbinary uses the default list of supported platform triples. This results in the@build_bazel_apple_supportrepository getting unconditionally downloaded when youbazel run @rules_rust//tools/rust_analyzer:gen_rust_project, which is undesirable when you're not writing rust targeting ios.The apple support repository is downloaded because it's referenced whenever
triple_to_constraint_setis called (because it callsextra_ios_constraints). I'm not sure how exactly that's getting invoked throughcrates_vendor, but the easiest solution is to remove the ios entries from thesupported_platform_tripleslist. I also took the liberty of removing wasm and android given that it's unlikely that anyone is using bazel+rust-analyzer on those platforms.