Use _make_link_flags_darwin when target os is ios.
#1843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illicitonion
approved these changes
Feb 28, 2023
|
Not sure what's going on with CI, but it definitely seems unrelated to your change... @scentini is there a handy Googler who may know what's up with the Windows CI situation? |
Right now, `_make_link_flags_default` is used when the target os is `ios`. However, it makes use of `--whole-archive` and `--no-whole-archive` flags, which are not supported by `dyld`. As it is done for the `macos` target, we should use `-force_load` instead. `_make_link_flags_darwin` does that, therefore we should use it when linking for iOS.
I rebased, making the CI green! |
|
Thanks so much! |
ghost
deleted the
nyurik
pushed a commit
to nyurik/rules_rust
that referenced
this pull request
Mar 28, 2023
Right now, `_make_link_flags_default` is used when the target os is `ios`. However, it makes use of `--whole-archive` and `--no-whole-archive` flags, which are not supported by `dyld`. As it is done for the `macos` target, we should use `-force_load` instead. `_make_link_flags_darwin` does that, therefore we should use it when linking for iOS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now,
_make_link_flags_defaultis used when the target os isios. However, it makes use of--whole-archiveand--no-whole-archiveflags, which are not supported bydyld.As it is done for the
macostarget, we should use-force_loadinstead._make_link_flags_darwindoes that, therefore we should use it when linking for iOS.