Add T2 support for x86_64-unknown-none #1967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
UebelAndre
requested changes
May 12, 2023
There was a problem hiding this comment.
Thanks! This will also require that you update the crate_universe examples. You can do so by navigating to examples/crate_universe and running REPIN=1 bazel query .... Pass or fail, that command should update the cargo-bazel-lock.json files which you add to your PR.
UebelAndre
requested changes
May 12, 2023
amari
changed the title
Silcet
pushed a commit
to Silcet/rules_rust
that referenced
this pull request
Jul 10, 2023
* Add T2 support for x86-64-unknown-none * Regenerate documentation * Update crate_universe examples * Update no_std test --------- Co-authored-by: Amari Robinson <[email protected]>
Silcet
pushed a commit
to Silcet/rules_rust
that referenced
this pull request
Jul 10, 2023
* Add T2 support for x86-64-unknown-none * Regenerate documentation * Update crate_universe examples * Update no_std test --------- Co-authored-by: Amari Robinson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1263.