Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifying exec and target compatibility constraints #1971

Merged
merged 3 commits into from
May 19, 2023
Merged

Allow specifying exec and target compatibility constraints #1971

merged 3 commits into from
May 19, 2023

Commits on May 17, 2023

  1. Allow specifying exec and target compatibility constraints 

    Extra target triples may only be appropriate for specific platforms
(e.g. if you register a toolchain with the exec_triple
`x86_64-unknown-linux-gnu` with an extra target triple of
`x86_64-unknown-linux-musl`, you may want differing
`target_compatible_with` values for each of those two target triples.

This allows for specifying explicit `exec_compatible_with` lists per
toolchain (which was already supported by `rust_toolchain_repository`
just not proxied by `rust_repository_set`), and explicit
`target_compatible_with` lists, both for the default triple and for
extra ones.

I'm not 100% sure on our pre-existing assumption that every toolchain
supports compiling targeting its own exec platform, i.e. the
'`[exec_triple]`' part of https:/bazelbuild/rules_rust/blob/937e63399b111a6d7ee53b187e4d113300b089e9/rust/repositories.bzl#L845
but it _does_ generally hold, and supplying a way of removing that
default assumption is definitely a separate PR for another day if it
becomes relevant to anyone.
    @illicitonion
    illicitonion committed May 17, 2023
    Configuration menu
    Copy the full SHA
    5ac0e25 View commit details
    Browse the repository at this point in the history

  2. Regenerate documentation

    @illicitonion
    illicitonion committed May 17, 2023
    Configuration menu
    Copy the full SHA
    bcd1f35 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into platform-constraints

    @illicitonion
    illicitonion authored May 17, 2023
    Configuration menu
    Copy the full SHA
    f0724e8 View commit details
    Browse the repository at this point in the history