Add virtual deps to package, not virtual workspace root #2775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise on repinning, we get errors because virtual workspaces can't have deps. Repinning the multi_package example hit this problem.
UebelAndre
approved these changes
Aug 2, 2024
|
Should there be a new release for this? |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Yeah, I'll kick one off :) Thanks! |
fmeum
referenced
this pull request
in bazel-contrib/toolchains_llvm
Aug 2, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | rules_rust | bazel_dep | patch | `0.49.0` -> `0.49.1` | | [rules_rust](https://togithub.com/bazelbuild/rules_rust) | http_archive | patch | `0.49.0` -> `0.49.1` | --- ### Release Notes <details> <summary>bazelbuild/rules_rust (rules_rust)</summary> ### [`v0.49.1`](https://togithub.com/bazelbuild/rules_rust/releases/tag/0.49.1) [Compare Source](https://togithub.com/bazelbuild/rules_rust/compare/0.49.0...0.49.1) ##### 0.49.1 ##### Bzlmod ```python bazel_dep(name = "rules_rust", version = "0.49.1") ``` ##### WORKSPACE ```python load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "rules_rust", integrity = "sha256-vPcQEm9pdNwttW2exexMfGxOLFOwcotEw1t3CkgCS8k=", urls = ["https:/bazelbuild/rules_rust/releases/download/0.49.1/rules_rust-v0.49.1.tar.gz"], ) ``` Additional documentation can be found at: https://bazelbuild.github.io/rules_rust/#setup ##### What's Changed - Support alwayslink for linking with clang by [@​cerisier](https://togithub.com/cerisier) in [https:/bazelbuild/rules_rust/pull/2647](https://togithub.com/bazelbuild/rules_rust/pull/2647) - Add virtual deps to package, not virtual workspace root by [@​illicitonion](https://togithub.com/illicitonion) in [https:/bazelbuild/rules_rust/pull/2775](https://togithub.com/bazelbuild/rules_rust/pull/2775) - Release 0.49.1 by [@​illicitonion](https://togithub.com/illicitonion) in [https:/bazelbuild/rules_rust/pull/2776](https://togithub.com/bazelbuild/rules_rust/pull/2776) ##### New Contributors - [@​cerisier](https://togithub.com/cerisier) made their first contribution in [https:/bazelbuild/rules_rust/pull/2647](https://togithub.com/bazelbuild/rules_rust/pull/2647) **Full Changelog**: bazelbuild/rules_rust@0.49.0...0.49.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/bazel-contrib/toolchains_llvm). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise on repinning, we get errors because virtual workspaces can't have deps.
Repinning the multi_package example hit this problem.