Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure proto compiler attribute is consistent in prost_toolchain #2794

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Ensure proto compiler attribute is consistent in prost_toolchain #2794

merged 2 commits into from
Aug 15, 2024

Conversation

UebelAndre
Copy link
Collaborator

The deprecated attribute was passing a Target where the proto_toolchain is passing a FilesToRun provider. This ensures the two are consistent.

illicitonion
illicitonion approved these changes Aug 15, 2024
View reviewed changes
Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@UebelAndre UebelAndre added this pull request to the merge queue Aug 15, 2024
Merged via the queue into bazelbuild:main with commit 6409c9f Aug 15, 2024
3 checks passed
@UebelAndre UebelAndre linked an issue Aug 19, 2024 that may be closed by this pull request
prost_toolchain.proto_compiler missing files_to_run? #2800
Closed
@UebelAndre UebelAndre mentioned this pull request Aug 19, 2024
Closed
@UebelAndre UebelAndre deleted the prost branch August 20, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illicitonion illicitonion illicitonion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

prost_toolchain.proto_compiler missing files_to_run?
2 participants
@UebelAndre @illicitonion