Build rust_test targets using a crate name different from the underlying lib
#2803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR also makes `rust_test` put its compilation outputs in the same directory as the `rust_library` rule. This is a partial rollback of bazelbuild@1018533 and bazelbuild@26344d4.
felipeamp
added a commit
to felipeamp/rules_rust
that referenced
this pull request
Aug 28, 2024
…he underlying lib (bazelbuild#2803)" This reverts commit b4ccc97. That commit makes a behavior change, and thus should have been protected by a feature flag. This will be done in a future PR.
felipeamp
added a commit
to felipeamp/rules_rust
that referenced
this pull request
Sep 2, 2024
underlying lib This is a rollforward of bazelbuild#2803, but behind a feature flag. This PR also makes `rust_test` put its compilation outputs in the same directory as the `rust_library` rule (i.e. not in a `test-{hash}` subdirectory anymore). After this change both the `rust_library` and `rust_test` rules will put all its compilation outputs in the same directory, but there won't be any name collisions in non-sandboxed environments (see bazelbuild#1427 for more context). Issue: bazelbuild#2827
felipeamp
added a commit
to felipeamp/rules_rust
that referenced
this pull request
Sep 2, 2024
underlying lib This is a rollforward of bazelbuild#2803, but behind a feature flag. This PR also makes `rust_test` put its compilation outputs in the same directory as the `rust_library` rule (i.e. not in a `test-{hash}` subdirectory anymore). After this change both the `rust_library` and `rust_test` rules will put all its compilation outputs in the same directory, but there won't be any name collisions in non-sandboxed environments (see bazelbuild#1427 for more context). Issue: bazelbuild#2827
felipeamp
added a commit
to felipeamp/rules_rust
that referenced
this pull request
Sep 2, 2024
underlying lib This is a rollforward of bazelbuild#2803, but behind a feature flag. This PR also makes `rust_test` put its compilation outputs in the same directory as the `rust_library` rule (i.e. not in a `test-{hash}` subdirectory anymore). After this change both the `rust_library` and `rust_test` rules will put all its compilation outputs in the same directory, but there won't be any name collisions in non-sandboxed environments (see bazelbuild#1427 for more context). Issue: bazelbuild#2827
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 12, 2024
…lying lib (#2828) This is a rollforward of #2803, but behind the `incompatible_change_rust_test_compilation_output_directory` incompatible flag. This PR also makes `rust_test` put its compilation outputs in the same directory as the `rust_library` rule (i.e. not in a `test-{hash}` subdirectory anymore). After this change both the `rust_library` and `rust_test` rules will put all its compilation outputs in the same directory, but there won't be any name collisions in non-sandboxed environments (see #1427 for more context). Issue with context: #2827
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also makes
rust_testput its compilation outputs in the same directory as therust_libraryrule (i.e. not in atest-{hash}subdirectory anymore).After this change both the
rust_libraryandrust_testrules will put all its compilation outputs in the same directory, but there won't be any name collisions in non-sandboxed environments (see #1427 for more context).This is a partial rollback of 1018533 and 26344d4.