Add wasm64 support. #2866
Merged
Add wasm64 support. #2866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freeformstu
force-pushed
the
dev/add-wasm64-support
branch
from
a545c05
to
c40d27e
Compare
UebelAndre
requested changes
Sep 12, 2024
freeformstu
force-pushed
the
dev/add-wasm64-support
branch
from
b4fdfe2
to
76b5acd
Compare
freeform-andre
force-pushed
the
dev/add-wasm64-support
branch
from
76b5acd
to
886dfdf
Compare
|
I think the failing windows example is Ok to disable with a reference to: |
UebelAndre
requested changes
Sep 18, 2024
There was a problem hiding this comment.
wasm64-unknown-unknown doesn't have a std artifact according to https://doc.rust-lang.org/nightly/rustc/platform-support.html#tier-3
This would lead to failures in analysis (failing to fetch an artifact that doesn't exist) should anything match that platform. I think it should be removed as a default platform and users can use crates_repository.supported_platform_triples if they were to have a usable toolchain.
freeform-andre
force-pushed
the
dev/add-wasm64-support
branch
from
bb66669
to
68d3a59
Compare
freeform-andre
force-pushed
the
dev/add-wasm64-support
branch
from
68d3a59
to
ac7848a
Compare
UebelAndre
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
wasm64-unknown-unknownalthough there are no prebuiltwasm64-unknown-unknownrustc toolchains. Compiling forwasm64will be left up to anyone using this target triple until we get T2 support for wasm64.