Restore lost "is_absolute" #2922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`is_absolute` was lost for "=" case in bazelbuild#2911 Fixes bazelbuild#2917
This was referenced Oct 6, 2024
UebelAndre
requested changes
Oct 6, 2024
|
I am not sure how to do that in reasonable way. Looks like there is no a single test which fail if I "return []" from _pwd_flags. I am very new to this code, could you please suggest which test could be the likely example for requested test? |
UebelAndre
approved these changes
Oct 6, 2024
vitalybuka
added a commit
to vitalybuka/rules_rust
that referenced
this pull request
Oct 7, 2024
Follow up to bazelbuild#2922. Before bazelbuild#2922 the only possible "else" with "opt" was space separated flags. Now we get there for already `is_absolute` path.
UebelAndre
added a commit
to UebelAndre/rules_rust
that referenced
this pull request
Oct 7, 2024
This reverts commit 2a85e13.
Merged
zemnmez-renovate-bot
added a commit
to zemn-me/monorepo
that referenced
this pull request
Oct 7, 2024
##### [`v0.52.2](https:/bazelbuild/rules_rust/releases/tag/0.52.2) ### 0.52.2 #### Bzlmod ```python bazel_dep(name = "rules_rust", version = "0.52.2") ``` #### WORKSPACE ```python load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "rules_rust", integrity = "sha256-Zx3bP+Xrz53TTQUeynNS+68z+lO/Ye7Qt1pMNIKeVIA=", urls = ["https:/bazelbuild/rules_rust/releases/download/0.52.2/rules_rust-v0.52.2.tar.gz"], ) ``` Additional documentation can be found at: https://bazelbuild.github.io/rules_rust/#setup #### What's Changed - Restore lost "is_absolute" by [@vitalybuka](https:/vitalybuka) in bazelbuild/rules_rust#2922 - Revert [#2911](bazelbuild/rules_rust#2911) and [#2922](bazelbuild/rules_rust#2922) by [@UebelAndre](https:/UebelAndre) in bazelbuild/rules_rust#2925 **Full Changelog**: bazelbuild/rules_rust@0.52.1...0.52.2
github-merge-queue bot
pushed a commit
to zemn-me/monorepo
that referenced
this pull request
Oct 8, 2024
##### [`v0.52.2](https:/bazelbuild/rules_rust/releases/tag/0.52.2) ### 0.52.2 #### Bzlmod ```python bazel_dep(name = "rules_rust", version = "0.52.2") ``` #### WORKSPACE ```python load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "rules_rust", integrity = "sha256-Zx3bP+Xrz53TTQUeynNS+68z+lO/Ye7Qt1pMNIKeVIA=", urls = ["https:/bazelbuild/rules_rust/releases/download/0.52.2/rules_rust-v0.52.2.tar.gz"], ) ``` Additional documentation can be found at: https://bazelbuild.github.io/rules_rust/#setup #### What's Changed - Restore lost "is_absolute" by [@vitalybuka](https:/vitalybuka) in bazelbuild/rules_rust#2922 - Revert [#2911](bazelbuild/rules_rust#2911) and [#2922](bazelbuild/rules_rust#2922) by [@UebelAndre](https:/UebelAndre) in bazelbuild/rules_rust#2925 **Full Changelog**: bazelbuild/rules_rust@0.52.1...0.52.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_absolutewas lost for "=" case in #2911Fixes #2917