Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register java toolchain inside rules_scala #1505

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Register java toolchain inside rules_scala #1505

merged 1 commit into from
Jul 17, 2023

Conversation

kotlaja
Copy link
Contributor

@kotlaja kotlaja commented Jul 14, 2023

Description

Any rule which uses java_common should register java toolchain_type.

@kotlaja kotlaja mentioned this pull request Jul 14, 2023
Closed
liucijus
liucijus approved these changes Jul 14, 2023
View reviewed changes
Copy link
Collaborator

@liucijus liucijus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @kotlaja!

@liucijus liucijus merged commit 30f8fbe into bazelbuild:master Jul 17, 2023
1 check passed
@meteorcloudy meteorcloudy mentioned this pull request Jul 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liucijus liucijus liucijus approved these changes

@simuons simuons Awaiting requested review from simuons simuons is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kotlaja @liucijus