Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a check function to gen_maven_deps.sh to verify that generated files match what's expected from the Yaml #85

Closed
greggdonovan opened this issue Oct 13, 2017 · 2 comments
Closed

Add a check function to gen_maven_deps.sh to verify that generated files match what's expected from the Yaml #85

greggdonovan opened this issue Oct 13, 2017 · 2 comments

Comments

@greggdonovan
Copy link
Contributor

See discussion here.

We run check-deps.sh in CI to make sure that the yaml and generated files are in sync. It'd be nice to move the logic of the check into bazel-deps.
@johnynek
Copy link
Collaborator

This is a good idea. It shouldn't be too hard since we don't actually have to parse the files, just diff them.

@kevingessner
Copy link
Contributor

I'm going to take a stab at this.

kevingessner added a commit to kevingessner/bazel-deps that referenced this issue Oct 16, 2017
@kevingessner
add --check-only flag to generate command (fixes bazeltools#85)
e317f13 
If present, this flag causes the generate command to resolve all dependencies as usual, but does not write the files.
Instead, it checks that each generated file on disk has the expected content.  If any files do not match the expected
content, they are logged and bazel-deps exits with code 2; bazel-deps exits 0 if everything matches.
@ittaiz ittaiz mentioned this issue Oct 16, 2017
Merged
kevingessner added a commit to kevingessner/bazel-deps that referenced this issue Oct 17, 2017
@kevingessner
add --check-only flag to generate command (fixes bazeltools#85)
4ec5211 
If present, this flag causes the generate command to resolve all dependencies as usual, but does not write the files.
Instead, it checks that each generated file on disk has the expected content.  If any files do not match the expected
content, they are logged and bazel-deps exits with code 2; bazel-deps exits 0 if everything matches.
kevingessner added a commit to kevingessner/bazel-deps that referenced this issue Oct 17, 2017
@kevingessner
add --check-only flag to generate command (fixes bazeltools#85)
80792db 
If present, this flag causes the generate command to resolve all dependencies as usual, but does not write the files.
Instead, it checks that each generated file on disk has the expected content.  If any files do not match the expected
content, they are logged and bazel-deps exits with code 2; bazel-deps exits 0 if everything matches.
@greggdonovan greggdonovan mentioned this issue Oct 29, 2017
Merged
greggdonovan added a commit to greggdonovan/BUILD_file_generator that referenced this issue Oct 31, 2017
@greggdonovan
Update check-deps now that bazeltools/bazel-deps#85 has been closed…
09e7ed8 
… but bazeltools/bazel-deps#62 is still open.
@greggdonovan greggdonovan mentioned this issue Oct 31, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@johnynek @greggdonovan @kevingessner