Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[In Progress] Efficient mode #335

Merged
merged 13 commits into from
Dec 1, 2015
Merged

[In Progress] Efficient mode #335

merged 13 commits into from
Dec 1, 2015

Conversation

ChrisBAshton
Copy link
Contributor

PR to merge into develop branch.

Basically changes the jobs batch, from this:

[
["clickable_guide__after_click", "/news/entertainment-arts-27221191", 320, "http://www.bbc.co.uk/news/entertainment-arts-27221191", "shots/clickable_guide__after_click/320_casperjs_english.png", ".idt__news", "false", "javascript/beforeCapture--casper_example.js"],
["clickable_guide__after_click", "/news/entertainment-arts-27221191", "600x768", "http://www.bbc.co.uk/news/entertainment-arts-27221191", "shots/clickable_guide__after_click/600x768_casperjs_english.png", ".idt__news", "false", "javascript/beforeCapture--casper_example.js"],
["clickable_guide__after_click", "/news/entertainment-arts-27221191", 768, "http://www.bbc.co.uk/news/entertainment-arts-27221191", "shots/clickable_guide__after_click/768_casperjs_english.png", ".idt__news", "false", "javascript/beforeCapture--casper_example.js"],
["clickable_guide__after_click", "/news/entertainment-arts-27221191", 1024, "http://www.bbc.co.uk/news/entertainment-arts-27221191", "shots/clickable_guide__after_click/1024_casperjs_english.png", ".idt__news", "false", "javascript/beforeCapture--casper_example.js"],
["clickable_guide__after_click", "/news/entertainment-arts-27221191", 1280, "http://www.bbc.co.uk/news/entertainment-arts-27221191", "shots/clickable_guide__after_click/1280_casperjs_english.png", ".idt__news", "false", "javascript/beforeCapture--casper_example.js"]
]

to this:

[
["clickable_guide__after_click", "/news/entertainment-arts-27221191", ['320', '600x768', '768', '1024', '1280'], "http://www.bbc.co.uk/news/entertainment-arts-27221191", "shots/clickable_guide__after_click/[320, \"600x768\", 768, 1024, 1280]_casperjs_english.png", ".idt__news", "false", "javascript/beforeCapture--casper_example.js"]
]

@ChrisBAshton ChrisBAshton changed the title Efficient mode [In Progress] Efficient mode Nov 30, 2015
@ChrisBAshton ChrisBAshton mentioned this pull request Nov 30, 2015
Merged
ChrisBAshton added a commit that referenced this pull request Dec 1, 2015
@ChrisBAshton
Merge pull request #335 from BBC-News/efficient_mode
14c9a44 
[In Progress] Efficient mode
@ChrisBAshton ChrisBAshton merged commit 14c9a44 into develop Dec 1, 2015
@ChrisBAshton ChrisBAshton deleted the efficient_mode branch December 2, 2015 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ChrisBAshton