Spider option should autogenerate the spider.yml file if the imported… #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… file does not exist
|
Looks like the build is erroring out because the current version of nokogiri requires ruby >= 2.1.0. Do you want to pin nokogiri to an older version or should I upgrade the ruby version? |
|
Thanks for bringing that to my attention, @ThomasWunderlich - I have hopefully fixed the build in #505. Could you merge master into your branch so that the tests are run against this PR again? |
|
@ChrisBAshton , |
|
Thanks - your fix looks good, I think we intended to pass the Will merge and release as 4.0.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix for issue #498, this configures the spider option so that the imports file is autogenerated if it doesn't exist