Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand Builder API and converter API so CLI can reference filepaths #158

Closed
bbottema opened this issue Aug 8, 2018 · 1 comment
Closed

Expand Builder API and converter API so CLI can reference filepaths #158

bbottema opened this issue Aug 8, 2018 · 1 comment
Assignees
@bbottema
Labels
enhancement invalid

Comments

@bbottema
Copy link
Owner

bbottema commented Aug 8, 2018

In order to fully support #156, all API should support file references which can be past from the CLI. This means we need to be able to read files directly.

This goes for the EmailBuilder API (specifically attachments, embedded images, HTML quote template etc.) as well as the EmailConverter API, since we should be able to reference .msg and .eml from terminal.
bbottema added a commit that referenced this issue Aug 8, 2018
@bbottema
#158: added support for loading .msg and .eml files from file system
d14f23a
@bbottema bbottema self-assigned this Aug 8, 2018
@bbottema bbottema added this to the 6.0.0 milestone Aug 8, 2018
@bbottema
Copy link
Owner Author

bbottema commented Nov 22, 2018 •
edited
Loading

This was solved by always converting .msg and .eml to MimeMessage, which is already there in the API.

@bbottema bbottema removed this from the 6.0.0 milestone Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbottema bbottema

Labels
enhancement invalid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bbottema