Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backmerge test to dev #3311

Merged
merged 17 commits into from
Jul 6, 2023
Merged

Backmerge test to dev #3311

merged 17 commits into from
Jul 6, 2023

Conversation

asanchezr
Copy link
Collaborator

No description provided.

PryancaJSharma and others added 17 commits June 22, 2023 10:24
* Set Lease Payment Status

Set all null lease payment statuses to their correct value based on the lease  term's payment amount + GST

* Set Lease Payment Status

Set all null lease payment statuses to their correct value based on the lease  term's payment amount + GST

* Drop Payee Check Constraint

* Drop Payee Check Constraint

* Changes related to Acquisition Payee

* ACQ_CHQ_PAYEE_ID_SEQ Removal

* Removed extra scripts
* Fix typo

* Align financial values to the right

* Typo

* Move "generate H120" button to requisition details header

* Update snapshots
* psp-6425 ensure that a new property added to a lease shows up on the map without requiring manual refresh. (bcgov#3296)

* psp-6442 filter expired codes, correct code value displays. (bcgov#3300)

* HOTFIX: Psp 6408 - separate unmounted vs. error map search behaviour. (bcgov#3297)

* separate unmounted vs error behaviour on usemapsearch.

* test corrections.

* correct try/catch location.

* psp-6499 ensure access request region is being populated when accepting an AR. (bcgov#3301)

* financial activity code instead of id, concurrency control and update corrections. (bcgov#3305)

* bump version number for 4.0 (bcgov#3306)

---------

Co-authored-by: devinleighsmith <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

✅ No secrets were detected in the code.

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #3311 (39ec3c3) into dev (b6c84d5) will decrease coverage by 5.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3311      +/-   ##
==========================================
- Coverage   72.75%   67.69%   -5.07%     
==========================================
  Files        1300      463     -837     
  Lines       30164    13795   -16369     
  Branches     5536      974    -4562     
==========================================
- Hits        21946     9338   -12608     
+ Misses       7980     4219    -3761     
  Partials      238      238              
Flag Coverage Δ
unittests 67.69% <ø> (-5.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/backend/dal.keycloak/PimsKeycloakService.cs 100.00% <ø> (ø)

... and 837 files with indirect coverage changes

@asanchezr asanchezr merged commit 63b61e9 into bcgov:dev Jul 6, 2023
@asanchezr asanchezr deleted the backmerge_test_to_dev branch July 6, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants