-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backmerge test to dev #3311
Merged
Merged
Backmerge test to dev #3311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
H120 Bugs
PSP - 6414 and 6418
TEST Release - IS56
* Set Lease Payment Status Set all null lease payment statuses to their correct value based on the lease term's payment amount + GST * Set Lease Payment Status Set all null lease payment statuses to their correct value based on the lease term's payment amount + GST * Drop Payee Check Constraint * Drop Payee Check Constraint * Changes related to Acquisition Payee * ACQ_CHQ_PAYEE_ID_SEQ Removal * Removed extra scripts
* Fix typo * Align financial values to the right * Typo * Move "generate H120" button to requisition details header * Update snapshots
* psp-6425 ensure that a new property added to a lease shows up on the map without requiring manual refresh. (bcgov#3296) * psp-6442 filter expired codes, correct code value displays. (bcgov#3300) * HOTFIX: Psp 6408 - separate unmounted vs. error map search behaviour. (bcgov#3297) * separate unmounted vs error behaviour on usemapsearch. * test corrections. * correct try/catch location. * psp-6499 ensure access request region is being populated when accepting an AR. (bcgov#3301) * financial activity code instead of id, concurrency control and update corrections. (bcgov#3305) * bump version number for 4.0 (bcgov#3306) --------- Co-authored-by: devinleighsmith <[email protected]>
asanchezr
requested review from
devinleighsmith,
FuriousLlama,
stairaku,
PryancaJSharma,
eddherrera and
buddy326
as code owners
July 6, 2023 21:18
✅ No secrets were detected in the code. |
devinleighsmith
approved these changes
Jul 6, 2023
Codecov Report
@@ Coverage Diff @@
## dev #3311 +/- ##
==========================================
- Coverage 72.75% 67.69% -5.07%
==========================================
Files 1300 463 -837
Lines 30164 13795 -16369
Branches 5536 974 -4562
==========================================
- Hits 21946 9338 -12608
+ Misses 7980 4219 -3761
Partials 238 238
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.