Skip to content

Commit

Permalink
fix: updating cove coverage report (#197)
Browse files Browse the repository at this point in the history
* fix: updating cove coverage report

* chore: updating unit tests

* fix: fixing coverage report

* fix: removing report from main and changed token
  • Loading branch information
paulushcgcj authored Nov 29, 2023
1 parent c393b65 commit 9b7009a
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 15 deletions.
18 changes: 4 additions & 14 deletions .github/workflows/merge-main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,14 +40,6 @@ jobs:
-Dsonar.tests=test
sonar_token: ${{ secrets.SONAR_TOKEN_BACKEND }}

- name: Report code coverage
uses: romeovs/[email protected]
with:
title: Backend coverage report
delete-old-comments: true
github-token: ${{ secrets.GHCR_TOKEN }}
lcov-file: ./backend/coverage/lcov.info

codeql:
name: Semantic Code Analysis
runs-on: ubuntu-22.04
Expand Down Expand Up @@ -94,8 +86,7 @@ jobs:
oc_token: ${{ secrets.OC_TOKEN }}
overwrite: false
penetration_test: false
parameters:
-p ZONE=${{ env.ZONE }} -p NAME=${{ github.event.repository.name }}
parameters: -p ZONE=${{ env.ZONE }} -p NAME=${{ github.event.repository.name }}

deploy-test-backend:
name: Deploy Backend on Test Env
Expand All @@ -115,7 +106,7 @@ jobs:
oc_server: ${{ secrets.OC_SERVER }}
oc_token: ${{ secrets.OC_TOKEN }}
overwrite: true
penetration_test: true
penetration_test: true
parameters:
-p ZONE=${{ env.ZONE }} -p NAME=${{ github.event.repository.name }}
-p PROMOTE=${{ github.repository }}/backend:${{ env.ZONE }}
Expand Down Expand Up @@ -147,8 +138,7 @@ jobs:
oc_token: ${{ secrets.OC_TOKEN }}
overwrite: false
penetration_test: false
parameters:
-p ZONE=${{ env.ZONE }} -p NAME=${{ github.event.repository.name }}
parameters: -p ZONE=${{ env.ZONE }} -p NAME=${{ github.event.repository.name }}

deploy-prod-backend:
name: Deploy Backend on Prod Env
Expand All @@ -169,7 +159,7 @@ jobs:
oc_server: ${{ secrets.OC_SERVER }}
oc_token: ${{ secrets.OC_TOKEN }}
overwrite: true
penetration_test: true
penetration_test: true
parameters:
-p ZONE=${{ env.ZONE }} -p NAME=${{ github.event.repository.name }}
-p PROMOTE=${{ github.repository }}/backend:${{ env.PREV }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
with:
title: Backend coverage report
delete-old-comments: true
github-token: ${{ secrets.GHCR_TOKEN }}
github-token: ${{ github.token }}
lcov-file: ./backend/coverage/lcov.info

trivy:
Expand Down
6 changes: 6 additions & 0 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"sonarlint.connectedMode.project": {
"connectionId": "bcgov-sonarcloud",
"projectKey": "bcgov_nr-old-growth"
}
}

0 comments on commit 9b7009a

Please sign in to comment.