Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: get PR numbers from API not commit messages #1652

Merged
merged 11 commits into from
Nov 21, 2023
Merged

refactor: get PR numbers from API not commit messages #1652

merged 11 commits into from
Nov 21, 2023

Conversation

DerekRoberts
Copy link
Member

@DerekRoberts DerekRoberts commented Nov 21, 2023 •
edited
Loading

  • Addresses input validation/sanitization from user-generated commits
  • Closes Dependabot alert for Expression injection in Actions
  • Replaces commit scrubbing with call to GitHub API

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@DerekRoberts DerekRoberts linked an issue Nov 21, 2023 that may be closed by this pull request
Fix code scanning alert - Expression injection in Actions #1651
Closed
1 task
@DerekRoberts DerekRoberts self-assigned this Nov 21, 2023
@DerekRoberts DerekRoberts marked this pull request as ready for review November 21, 2023 20:36
@DerekRoberts DerekRoberts changed the title refactor: get PR numbers from merges refactor: get PR numbers from merges not commit messages Nov 21, 2023
@DerekRoberts DerekRoberts added enhancement New feature or request github_actions Pull requests that update GitHub Actions code labels Nov 21, 2023
@DerekRoberts DerekRoberts changed the title refactor: get PR numbers from merges not commit messages refactor: get PR numbers from API not commit messages Nov 21, 2023
@DerekRoberts DerekRoberts merged commit f1bc229 into main Nov 21, 2023
13 checks passed
@DerekRoberts DerekRoberts deleted the fix/stopScrubbingCommits branch November 21, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mishraomp mishraomp Awaiting requested review from mishraomp

Assignees

@DerekRoberts DerekRoberts

Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code
Projects
DevOps (NR)
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix code scanning alert - Expression injection in Actions
1 participant
@DerekRoberts