Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #180 #181

Merged
merged 4 commits into from
Jul 1, 2024
Merged

Fix #180 #181

merged 4 commits into from
Jul 1, 2024

Conversation

PhilipVinc
Copy link
Collaborator

@PhilipVinc PhilipVinc commented Jul 1, 2024

Only use typing extensions if truly needed.
We should eventually add a CI test without all the de dependencies, because they probably bring in typing extensions in other versions....

@PhilipVinc PhilipVinc merged commit aac1bd3 into beartype:master Jul 1, 2024
5 of 6 checks passed
@PhilipVinc PhilipVinc deleted the fix branch July 1, 2024 09:16
@PhilipVinc
Copy link
Collaborator Author

PhilipVinc commented Jul 1, 2024

@wesselb want to tag a minor or patch version? Technically should be minor because we deprecated Val...

@coveralls
Copy link

coveralls commented Jul 1, 2024

Pull Request Test Coverage Report for Build 9741493491

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.92%

Totals Coverage Status
Change from base Build 9723266109: 0.0%
Covered Lines: 1254
Relevant Lines: 1255

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 1, 2024

Pull Request Test Coverage Report for Build 9741510339

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.92%

Totals Coverage Status
Change from base Build 9723266109: 0.0%
Covered Lines: 1254
Relevant Lines: 1255

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 1, 2024

Pull Request Test Coverage Report for Build 9741498270

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.92%

Totals Coverage Status
Change from base Build 9723266109: 0.0%
Covered Lines: 1254
Relevant Lines: 1255

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 1, 2024

Pull Request Test Coverage Report for Build 9741543209

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.92%

Totals Coverage Status
Change from base Build 9723266109: 0.0%
Covered Lines: 1254
Relevant Lines: 1255

💛 - Coveralls

@wesselb
Copy link
Member

wesselb commented Jul 2, 2024

@PhilipVinc Let's release a minor version. Will do right away!

@wesselb
Copy link
Member

wesselb commented Jul 2, 2024

Thanks for being on top of this!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants