Fix incorrect instructions names in ARM32 scanners #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing and re-opening to trigger the CI. |
For unknown reasons some of the NEON instructions has been updated in the PIE arm and thumb definitions without reflecting those changes in the aarch32 scanners. As a result MAMBO does not compile for 32-bit architectures. This commit adjusts the names in the scanner to match defintions in PIE.wq
|
This PR also fixes problem with mapping of reserved space on A32. |
For unknown reasons when RESERVED_BRK_SPACE is set to 128 * PAGE_SIZE MABMO segfaults on scanning the first instructions. The problem first transpires after mmap and remmap involving RESERVED_BRK_SPACE is executed. This fix reduces the reserved space back to PAGE_SIZE for A32 - the value used before RISC-V merge. One of the possible explnations is smaller virtual memory on A32 compared to A64 and RISC-V.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For unknown reasons some of the NEON instructions has been updated in the PIE arm and thumb definitions without reflecting those changes in the aarch32 scanners. As a result MAMBO does not compile for 32-bit architectures. This commit adjusts the names in the scanner to match definitions in PIE.