Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] beesdoo_shift: Don't raise an error when worker_id is undefined #389

Merged
merged 7 commits into from
May 26, 2022

Conversation

carmenbianca
Copy link
Collaborator

Description

Odoo task (if applicable)

https://gestion.coopiteasy.be/web#view_type=form&model=project.task&id=8529&active_id=8529&menu_id=

Checklist before approval

  • Tests are present (or not needed).
  • Credits/copyright have been changed correctly.
  • (If a new module) Moving this to OCA has been considered.

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2022

Codecov Report

Merging #389 (8b1b28c) into 12.0 (a23e23c) will decrease coverage by 0.02%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             12.0     #389      +/-   ##
==========================================
- Coverage   69.20%   69.18%   -0.03%     
==========================================
  Files         109      109              
  Lines        3445     3446       +1     
  Branches      603      604       +1     
==========================================
  Hits         2384     2384              
  Misses        948      948              
- Partials      113      114       +1     
Impacted Files Coverage Δ
beesdoo_shift/models/task.py 76.82% <66.66%> (-0.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a23e23c...8b1b28c. Read the comment docs.

@carmenbianca
Copy link
Collaborator Author

/ocabot rebase

please

In `unsubscribe_from_today`, `worker_id` is set to `False`. Eventually
this causes an exception to be raised here. This tiny patch should
prevent that.

Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
@carmenbianca carmenbianca force-pushed the 12.0-fix-worker-none branch 2 times, most recently from 6a6e61d to 8b1b28c Compare May 23, 2022 12:27
The default keyword argument in `copy()` didn't automatically set the
`is_regular` field to True for unknown reasons.

Signed-off-by: Carmen Bianca Bakker <[email protected]>
Copy link
Collaborator

@remytms remytms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@remytms
Copy link
Collaborator

remytms commented May 26, 2022

/ocabot merge patch

@remytms remytms merged commit b43e80e into 12.0 May 26, 2022
@remytms remytms deleted the 12.0-fix-worker-none branch May 26, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants