[FIX] beesdoo_shift: Check working mode as well as shift_id #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 12.0 #390 +/- ##
=======================================
Coverage 69.20% 69.20%
=======================================
Files 109 109
Lines 3445 3445
Branches 603 603
=======================================
Hits 2384 2384
Misses 948 948
Partials 113 113
Continue to review full report at Codecov.
|
|
When approved, let's try merging this with OCA bot. It's a patch-level fix. |
carmenbianca
assigned huguesdk, remytms and victor-champonnois and unassigned huguesdk, remytms and victor-champonnois
Previously the error would be shown when changing a regular worker to an irregular worker, because the `shift_id` field was not erased. Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
remytms
force-pushed
the
12.0-fix-regular-to-irregular
branch
from
6877943
to
f416a46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously the error would be shown when changing a regular worker to an
irregular worker, because the
shift_idfield was not erased.Odoo task (if applicable)
https://gestion.coopiteasy.be/web#view_type=form&model=project.task&id=8482&active_id=8482&menu_id=
Checklist before approval