Use pure pyproject.toml setup for packaging
#155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bittner
force-pushed
the
feature/pure-pyproject-toml-packaging
branch
2 times, most recently
from
d81da36
to
4433d0d
Compare
Modern setuptools that reads all attributes from `pyproject.toml` needs Python 3.7+.
bittner
force-pushed
the
feature/pure-pyproject-toml-packaging
branch
from
4433d0d
to
e3f1e44
Compare
kingbuzzman
reviewed
Feb 12, 2024
kingbuzzman
reviewed
Feb 12, 2024
kingbuzzman
reviewed
Feb 12, 2024
kingbuzzman
reviewed
Feb 12, 2024
| @@ -8,7 +8,7 @@ envlist = | |||
| isort | |||
| pylint | |||
| # Python/Django combinations that are officially supported | |||
| py3{6,7,8,9,10}-django32 | |||
| py3{7,8,9,10}-django32 | |||
There was a problem hiding this comment.
Any particular reason for tox now? Figured with github actions, this was moot.
There was a problem hiding this comment.
Tox is a tool that belongs to the development layer. It abstracts the details of running tests and linting away. Last but not least, it allows to run all the things locally, without the automation component.
I guess it's here to stay. Is there any good reason to get rid of it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phases out
setup.pyandrequirements.txtin a quest to modernize packaging.This PR also drops support for Python 3.6, which is not supported by newer versions of setuptools required to read all values out of
pyproject.toml(e.g. name and authors).