Use object ids instead of hashes for Jekyll documents #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed solution for #16.
This change drastically improves performance when passing posts, documents or pages, e.g.
The problem with doing the above is the long time it takes to calculate the
.hash
of a large Jekyll document, such as a post.However, it should be safe to assume that documents don't change during a page build, so using the
object_id
instead of thehash
for comparison results in a large performance boost.The implementation only applies to known Jekyll types, so that other complex data still get the old treatment, e.g.
still works, even if
data
is passed in multiple places with different object ids.