Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies: bump Rubocop to 0.5.1 #5

Merged
merged 1 commit into from
Dec 26, 2017
Merged

Conversation

DirtyF
Copy link
Contributor

@DirtyF DirtyF commented Oct 23, 2017

I forgot to do that in #4 😊

@benbalter Just to know what actions to take after a Jekyll release, what would you recommend for dependencies bump in plugins?

  • Should plugins follow the latest Jekyll version? (We bumped Rubocop to 0.5.1 in 3.6.2)
  • Should we allow bundler to get latest patch releases? (e.g, 0.5 instead of 0.5.1 here)

@benbalter
Copy link
Owner

benbalter commented Oct 23, 2017

@DirtyF if plugins have

inherit_gem:
  jekyll: .rubocop.yml

My personal 2 cents is to follow the latest stable Jekyll within whatever pessimistic constraints its gemspec defines, meaning I'm fine if a plugin gets a patch release, but am not strongly opinionated and defer to you as long as we're consistent / it doesn't cause headaches or more work.

@stale
Copy link

stale bot commented Dec 22, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Dec 22, 2017
@benbalter benbalter merged commit 65f8540 into benbalter:master Dec 26, 2017
@DirtyF DirtyF deleted the patch-1 branch December 26, 2017 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants