-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement PNG decode adaptor iterator #207
Merged
Merged
Commits on Jul 21, 2022
-
Configuration menu - View commit details
-
Copy full SHA for b769b26 - Browse repository at this point
Copy the full SHA b769b26View commit details
Commits on Jul 26, 2022
-
Implement decode_png adaptor iterator
This incomplete PNG decoder presents as an Iterator reading u8 bytes directly from a Reader. Aproaching a png decoder as an Iterator requires significantly less Heap than the traditional batch aproach. On Precursor, this enables PNG bytes to be intercepted at the network interface and processed into the much smaller gam::Bitmap format without ever having to store the original PNG file.
Configuration menu - View commit details
-
Copy full SHA for 7cd5ee8 - Browse repository at this point
Copy the full SHA 7cd5ee8View commit details
Commits on Jul 27, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 1357d39 - Browse repository at this point
Copy the full SHA 1357d39View commit details -
Configuration menu - View commit details
-
Copy full SHA for 956eef4 - Browse repository at this point
Copy the full SHA 956eef4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 118f0c0 - Browse repository at this point
Copy the full SHA 118f0c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for dadaae2 - Browse repository at this point
Copy the full SHA dadaae2View commit details -
Configuration menu - View commit details
-
Copy full SHA for d82fba7 - Browse repository at this point
Copy the full SHA d82fba7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 938788d - Browse repository at this point
Copy the full SHA 938788dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 64f6dde - Browse repository at this point
Copy the full SHA 64f6ddeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d0ddc3 - Browse repository at this point
Copy the full SHA 2d0ddc3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 98586ff - Browse repository at this point
Copy the full SHA 98586ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for afef00a - Browse repository at this point
Copy the full SHA afef00aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7626be7 - Browse repository at this point
Copy the full SHA 7626be7View commit details -
Configuration menu - View commit details
-
Copy full SHA for f95a49d - Browse repository at this point
Copy the full SHA f95a49dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1923a9c - Browse repository at this point
Copy the full SHA 1923a9cView commit details -
Configuration menu - View commit details
-
Copy full SHA for f9ee19e - Browse repository at this point
Copy the full SHA f9ee19eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7af94e6 - Browse repository at this point
Copy the full SHA 7af94e6View commit details
Commits on Jul 28, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 27ac3d9 - Browse repository at this point
Copy the full SHA 27ac3d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b7c63c - Browse repository at this point
Copy the full SHA 9b7c63cView commit details
Commits on Aug 6, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 4ddcabc - Browse repository at this point
Copy the full SHA 4ddcabcView commit details
Commits on Aug 7, 2022
-
ignore png_decode chunk checksums
The checksum calc is inner-loop so removed for performance gain. If a hacker can manipulate a byte then then they can manipulate a RGB byte or a checksum byte - so the checksum doesn't really give any protection from hacking afaik. I presume the checksum is in there to detect corruption during storage or transmission - but if a couple of bytes are corrupted you will not notice the change in the image - and if a lot of bytes are corrupted then the distortion in the image will be obvious. This is even more the case in Precursor, where we are shrinking and dithering the image as a matter of course. So I don't really see the point of the checkum
Configuration menu - View commit details
-
Copy full SHA for 155373b - Browse repository at this point
Copy the full SHA 155373bView commit details -
bugfix distortion in png_decode
png filter specification calls for initial prior_line = [0u8] see: https://www.w3.org/TR/PNG/#9Filters but [0u8] results in distortion ??????? so use [125u8]
Configuration menu - View commit details
-
Copy full SHA for 76bb796 - Browse repository at this point
Copy the full SHA 76bb796View commit details
Commits on Aug 8, 2022
-
Configuration menu - View commit details
-
Copy full SHA for d96faec - Browse repository at this point
Copy the full SHA d96faecView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.