Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement PNG decode adaptor iterator #207

Merged
merged 23 commits into from
Aug 10, 2022
Merged

Commits on Jul 21, 2022

  1. Configuration menu
    Copy the full SHA
    b769b26 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2022

  1. Implement decode_png adaptor iterator

    This incomplete PNG decoder presents as an Iterator reading u8 bytes directly from a Reader.
    
    Aproaching a png decoder as an Iterator requires significantly less Heap than
    the traditional batch aproach.
    
    On Precursor, this enables PNG bytes to be intercepted at the network interface
    and processed into the much smaller gam::Bitmap format without ever having to
    store the original PNG file.
    nworbnhoj committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    7cd5ee8 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2022

  1. Configuration menu
    Copy the full SHA
    1357d39 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    956eef4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    118f0c0 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    dadaae2 View commit details
    Browse the repository at this point in the history
  5. remove redundant comments

    nworbnhoj committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    d82fba7 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    938788d View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    64f6dde View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    2d0ddc3 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    98586ff View commit details
    Browse the repository at this point in the history
  10. breakout mod Img RGB raster

    nworbnhoj committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    afef00a View commit details
    Browse the repository at this point in the history
  11. rustfmt Bitmap

    nworbnhoj committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    7626be7 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    f95a49d View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    1923a9c View commit details
    Browse the repository at this point in the history
  14. fix merge blunder

    caused by flakey Internet connection
    nworbnhoj committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    f9ee19e View commit details
    Browse the repository at this point in the history
  15. fix Bitmap::from_png rotate

    nworbnhoj committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    7af94e6 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2022

  1. fix image modal center

    nworbnhoj committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    27ac3d9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9b7c63c View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2022

  1. Configuration menu
    Copy the full SHA
    4ddcabc View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2022

  1. ignore png_decode chunk checksums

    The checksum calc is inner-loop so removed for performance gain.
    
    If a hacker can manipulate a byte then then they can manipulate a RGB
    byte or a checksum byte - so the checksum doesn't really give any
    protection from hacking afaik. I presume the checksum is in there to
    detect corruption during storage or transmission - but if a couple of
    bytes are corrupted you will not notice the change in the image - and
    if a lot of bytes are corrupted then the distortion in the image will be
    obvious. This is even more the case in Precursor, where we are shrinking
    and dithering the image as a matter of course. So I don't really see the
    point of the checkum
    nworbnhoj committed Aug 7, 2022
    Configuration menu
    Copy the full SHA
    155373b View commit details
    Browse the repository at this point in the history
  2. bugfix distortion in png_decode

    png filter specification calls for initial prior_line = [0u8]
    see: https://www.w3.org/TR/PNG/#9Filters
    but [0u8] results in distortion ???????
    so use [125u8]
    nworbnhoj committed Aug 7, 2022
    Configuration menu
    Copy the full SHA
    76bb796 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2022

  1. add png_decode comments

    nworbnhoj committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    d96faec View commit details
    Browse the repository at this point in the history