Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for PreFixedUpdate/PostFixedUpdate #10974

Closed
alice-i-cecile opened this issue Dec 13, 2023 · 3 comments · Fixed by #10977
Closed

Add support for PreFixedUpdate/PostFixedUpdate #10974

alice-i-cecile opened this issue Dec 13, 2023 · 3 comments · Fixed by #10977
Labels
A-ECS Entities, components, systems, and events C-Feature A new feature, making something new possible

Comments

@alice-i-cecile
Copy link
Member 

          This might be another issue, but should we also add support for PreFixedUpdate/PostFixedUpdate? This same mechanism could be used for that too.

Someone in the discord was asking about PostFixedUpdate 😅

Originally posted by @andriyDev in #10969 (comment)
@alice-i-cecile alice-i-cecile added C-Feature A new feature, making something new possible A-ECS Entities, components, systems, and events labels Dec 13, 2023
@Aceeri
Copy link
Member

Aceeri commented Dec 13, 2023 •
edited
Loading

I actually was just talking about this as well and would be useful here: #10973

Right now it is a bit annoying to interact with 3rd party code in FixedUpdate because of the lack of these sets.

Should also mimic the First, Pre, Update, Post, Last to make it consistent with the main loop.

@andriyDev
Copy link
Contributor

Ah thank you for making this @alice-i-cecile!

@alice-i-cecile
Copy link
Member Author

"Reference in new issue" (the ... dots on each comment) is extremely convenient!

@Aceeri Aceeri mentioned this issue Dec 13, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Dec 14, 2023
@Aceeri
Add First/Pre/Post/Last schedules to the Fixed timestep (#10977)
fe28e0e 
Fixes #10974

# Objective
Duplicate the ordering logic of the `Main` schedule into the `FixedMain`
schedule.

---

## Changelog
- `FixedUpdate` is no longer the main schedule ran in
`RunFixedUpdateLoop`, `FixedMain` has replaced this and has a similar
structure to `Main`.

## Migration Guide
- Usage of `RunFixedUpdateLoop` should be renamed to `RunFixedMainLoop`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Feature A new feature, making something new possible
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add First/Pre/Post/Last schedules to the Fixed timestep Aceeri/bevy
3 participants
@alice-i-cecile @Aceeri @andriyDev