chore: use ExtractComponent derive macro for EnvironmentMapLight and FogSettings #10191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JMS55
approved these changes
Oct 19, 2023
jancespivo
force-pushed
the
chore/extract_component_clean
branch
from
3cc7475
to
354ae59
Compare
alice-i-cecile
added
A-Rendering
alice-i-cecile
approved these changes
Oct 19, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
ameknite
pushed a commit
to ameknite/bevy
that referenced
this pull request
Nov 6, 2023
…FogSettings (bevyengine#10191) I've done tiny cleanup when playing with code. ## Solution [derive macro](https:/bevyengine/bevy/blob/main/crates/bevy_render/macros/src/extract_component.rs) with `extract_component_filter` attribute generate the same code I removed. ## Migration Guide No migration needed
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
…FogSettings (bevyengine#10191) I've done tiny cleanup when playing with code. ## Solution [derive macro](https:/bevyengine/bevy/blob/main/crates/bevy_render/macros/src/extract_component.rs) with `extract_component_filter` attribute generate the same code I removed. ## Migration Guide No migration needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've done tiny cleanup when playing with code.
Solution
derive macro with
extract_component_filterattribute generate the same code I removed.Migration Guide
No migration needed