Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix deferred example fog values #10249

Merged
merged 1 commit into from
Oct 24, 2023
Merged

fix deferred example fog values #10249

merged 1 commit into from
Oct 24, 2023

Conversation

DGriffin91
Copy link
Contributor

@DGriffin91 DGriffin91 commented Oct 24, 2023 •
edited
Loading

Objective

Solution

After this update:
image

@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Oct 24, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 24, 2023
Merged via the queue into bevyengine:main with commit 6c74c8a Oct 24, 2023
25 checks passed
ameknite pushed a commit to ameknite/bevy that referenced this pull request Nov 6, 2023
@DGriffin91 @ameknite
fix deferred example fog values (bevyengine#10249)
605e0fb 
# Objective

- Fixes bevyengine#10248

## Solution

- Update fog color values matching the update to the values for
[atmospheric_fog.rs](https:/bevyengine/bevy/pull/10226/files#diff-d43c34c9cf52e7ee72b56f8c4fc99ed86e9a1ec2f83642b839c4e75e1dd24f87)
in bevyengine#10226

After this update:

![image](https:/bevyengine/bevy/assets/33357138/5924f97d-e12b-496e-90fa-160d20b82a2e)
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@DGriffin91
fix deferred example fog values (bevyengine#10249)
5b3b7b2 
# Objective

- Fixes bevyengine#10248

## Solution

- Update fog color values matching the update to the values for
[atmospheric_fog.rs](https:/bevyengine/bevy/pull/10226/files#diff-d43c34c9cf52e7ee72b56f8c4fc99ed86e9a1ec2f83642b839c4e75e1dd24f87)
in bevyengine#10226

After this update:

![image](https:/bevyengine/bevy/assets/33357138/5924f97d-e12b-496e-90fa-160d20b82a2e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@JMS55 JMS55 JMS55 approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fog in deferred doesn't work.
3 participants
@DGriffin91 @alice-i-cecile @JMS55