Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples showcase: use patches instead of sed for wasm hacks #10601

Merged
merged 1 commit into from
Nov 17, 2023
Merged

examples showcase: use patches instead of sed for wasm hacks #10601

merged 1 commit into from
Nov 17, 2023

Conversation

mockersf
Copy link
Member

Objective

  • Fix the asset hack for wasm examples so that they work on the website
  • Use patches instead of sed for wasm hacks so that it fails explicitly when they need to be updated

@mockersf mockersf added the C-Examples An addition or correction to our examples label Nov 17, 2023
@mockersf mockersf added this to the 0.12.1 milestone Nov 17, 2023
@alice-i-cecile alice-i-cecile added the O-Web Specific to web (WASM) builds label Nov 17, 2023
@cart cart added this pull request to the merge queue Nov 17, 2023
Merged via the queue into bevyengine:main with commit 7ee9f8e Nov 17, 2023
24 checks passed
cart pushed a commit that referenced this pull request Nov 30, 2023
@mockersf @cart
examples showcase: use patches instead of sed for wasm hacks (#10601)
c458093 
# Objective

- Fix the asset hack for wasm examples so that they work on the website
- Use patches instead of sed for wasm hacks so that it fails explicitly
when they need to be updated
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@mockersf
examples showcase: use patches instead of sed for wasm hacks (bevyeng…
b2fc228 
…ine#10601)

# Objective

- Fix the asset hack for wasm examples so that they work on the website
- Use patches instead of sed for wasm hacks so that it fails explicitly
when they need to be updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cart cart cart approved these changes

Assignees
No one assigned
Labels
C-Examples An addition or correction to our examples O-Web Specific to web (WASM) builds
Projects
None yet
Milestone
0.12.1
Development

Successfully merging this pull request may close these issues.
3 participants
@mockersf @cart @alice-i-cecile